Bug 251222

Summary:	[ews] Run ValidateChange just before CompileWebKit and major steps
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Description Aakash Jain 2023-01-26 12:34:16 PST

EWS builds should run ValidateChange just after completing all the checkout operations.

This becomes more important because of skip-ews support. When using git-webkit pr --no-ews, skip-ews label is added by our tooling slightly after the PR creation. It races with build starting on bots, and builds can start (and pass the ValidateChange step which happens in the beginning of the build) before skip-ews label was added by the tooling. Since git operations like CleanGitRepo, CheckOutSource, CheckOutPullRequest takes few minutes, we should do the validation after those steps as well.

Comment 1 Radar WebKit Bug Importer 2023-01-26 13:28:29 PST

<rdar://problem/104710968>

Comment 2 Aakash Jain 2023-01-26 13:39:44 PST

Pull request: https://github.com/WebKit/WebKit/pull/9187

Comment 3 Aakash Jain 2023-01-27 05:12:36 PST

Discussed with Jonathan. We also want to be conscious of number of api calls we make to GitHub as we might hit the api limit.

Changed it to run ValidateChange just before CompileWebKit and major steps.

Comment 4 EWS 2023-01-27 09:17:01 PST

Committed 259493@main (3808d4657839): <https://commits.webkit.org/259493@main>

Reviewed commits have been landed. Closing PR #9187 and removing active labels.