Bug 251057

Summary: AX: Use stronger typing of AccessibilityObject in AXObjectCache, AXIsolatedObject, and AXIsolatedTree
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Tyler Wilcock
Reported 2023-01-23 18:20:31 PST
We have a bunch of places where we pass an AXCoreObject and immediately ASSERT(is<AccessibilityObject>(object)). We should just use stronger types, which avoids asserts and casting, and possibly helps the compiler perform de-virtualization optimizations.
Attachments
Patch (12.51 KB, patch)
2023-01-23 18:22 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-01-23 18:20:44 PST
<rdar://problem/104582945>
Tyler Wilcock
Comment 2 2023-01-23 18:22:22 PST
Created attachment 464620 [details] Patch
EWS
Comment 3 2023-01-24 20:08:55 PST
Committed 259334@main (d7b129acb04c): <https://commits.webkit.org/259334@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464620 [details].
Note You need to log in before you can comment on or make changes to this bug.