Bug 251042

Summary:	Editing - Code refactoring to avoid several calls to hasEditableStyle() in loop
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	HTML Editing	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-01-23 14:27:13 PST

Hi Team,

I came across this possible merge, which is to avoid looping and reduce calls to hasEditableStyle() in VisibleUnits.cpp:

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/editing/VisibleUnits.cpp#1121 & https://searchfox.org/wubkat/source/Source/WebCore/editing/VisibleUnits.cpp#1178

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/85355b065acfc6ffbf960afa2d8e175104c556fa

It is just a refactoring to reduce calls, so I think it would be fine to land without any dedicated testcase.

Thanks!

Comment 1 EWS 2023-01-24 01:44:40 PST

Committed 259267@main (e2e91f349dc7): <https://commits.webkit.org/259267@main>

Reviewed commits have been landed. Closing PR #8993 and removing active labels.

Comment 2 Radar WebKit Bug Importer 2023-01-24 01:45:30 PST

<rdar://problem/104592394>