Bug 25101

Summary: run-webkit-tests should launch DumpRenderTree and the image diff tool in a way compatible with threads.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, ddkilzer, eric, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 10906    
Attachments:
Description Flags
Proposed fix.
ddkilzer: review-
Proposed fix. ddkilzer: review+

David Levin
Reported 2009-04-08 14:22:53 PDT
run-webkit-tests sets up ENV correctly and launches these programs, but on a perl threads use the main thread's environment instead of the current thread.
Attachments
Proposed fix. (7.21 KB, patch)
2009-04-08 14:45 PDT, David Levin 		ddkilzer: review-
DetailsFormatted DiffDiff
Proposed fix. (6.77 KB, patch)
2009-04-08 22:20 PDT, David Levin 		ddkilzer: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-04-08 14:45:06 PDT
Created attachment 29346 [details] Proposed fix.
Eric Seidel (no email)
Comment 2 2009-04-08 14:59:09 PDT
Yeah, this is something ddkilzer or bdash or darin adler would want to review (as our local perl gurus).
David Kilzer (:ddkilzer)
Comment 3 2009-04-08 18:03:59 PDT
Comment on attachment 29346 [details] Proposed fix. Overall this patch looks great, but I have two concerns: 1. The serialization of %ENV using regular expressions is very clever, but I think it would be more straight-forward if Data::Dumper were used to do the serializing, and "eval" to do the deserializing. The Data::Dumper module is present in all "modern" installations of Perl and it would simplify the code in run-webkit-tests and the utility script (ExecAppWithEnv.pm). Try this: $ perl -e 'use Data::Dumper; my $d = Data::Dumper->new([\%ENV], [qw(ENV)]); $d->Indent(0); $d->Purity(1); print $d->Dump();' Also, instead of using "escape" and "unescape", I think it's clearer to use "serialize" and "deserialize" when describing the process of moving %ENV to the subprocess. 2. Please rename "ExecAppWithEnv.pm" to something that resembles a script name like "execAppWithEnv". Naming it "ExecAppWithEnv.pm" made me think it was a Perl module, but it's not. It's a Perl script that is invoked by run-webkit-tests. r- to resolve the above issues. Thanks!
David Levin
Comment 4 2009-04-08 22:20:27 PDT
Created attachment 29358 [details] Proposed fix. Addressed feedback.
David Kilzer (:ddkilzer)
Comment 5 2009-04-09 06:10:18 PDT
Comment on attachment 29358 [details] Proposed fix. r=me Thanks!
David Kilzer (:ddkilzer)
Comment 6 2009-04-09 06:11:25 PDT
Comment on attachment 29358 [details] Proposed fix. >+ * Scripts/execAppWithEnv.pm: Added. Oops! This should just be "Scripts/execAppWithEnv". :)
David Levin
Comment 7 2009-04-09 09:15:48 PDT
Committed <http://trac.webkit.org/changeset/42359>
Note You need to log in before you can comment on or make changes to this bug.