| Summary: | [IFC] Rename LineBoxBuilder::adjustedLayoutBoundsWithFallbackFonts to enclosingAscentDescentWithFallbackFonts | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2023-01-22 08:40:44 PST
Created attachment 464593 [details]
Patch
Comment on attachment 464593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464593&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:154 > +AscentAndDescent LineBoxBuilder::enclosingAscentDescentWithFallbackFonts(InlineLevelBox& inlineBox, const TextUtil::FallbackFontList& fallbackFontsForContent, FontBaseline fontBaseline) const Can this take const InlineLevelBox&? (In reply to Antti Koivisto from comment #2) > Comment on attachment 464593 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=464593&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:154 > > +AscentAndDescent LineBoxBuilder::enclosingAscentDescentWithFallbackFonts(InlineLevelBox& inlineBox, const TextUtil::FallbackFontList& fallbackFontsForContent, FontBaseline fontBaseline) const > > Can this take const InlineLevelBox&? excellent point! Created attachment 464594 [details]
[fast-cq]Patch
Committed 259194@main (15e2f12c0c15): <https://commits.webkit.org/259194@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464594 [details]. |