Bug 250852

Summary: Bail out of networkStateChanged if allPages is NULL
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: beidson, cdumez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2023-01-19 10:32:37 PST
Hi Team,

While going through Blink's commit, I came across another potential fix, which can fix crashes etc.:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/e6b48197ee2a4eff890eb2cfbb1dcb4a50c75043

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/page/Page.cpp#240

Just wanted to raise to confirm if it is something worth fixing. Unfortunately, it does not have any test case.

Thanks!
Comment 1 Chris Dumez 2023-01-19 10:37:49 PST
allPages cannot be null in WebKit.