Bug 250799
| Summary: | [ews-build.webkit.org] Use super for parent class invocations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=298058 | ||
Jonathan Bedard
Throughout ews-build.webkit.org, we should use 'super' instead of explicitly invoking a class function. The reason for this is that 'super' calls will break unit tests very hard if our parent class doesn't have the function we're invoking, while directly invoking a member function of a class we aren't inherited from isn't nessesarily fatal. We're likely to make mistakes here as we switch certain steps to new-style.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/104400449>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/8798
EWS
Committed 259233@main (419bb9a7d871): <https://commits.webkit.org/259233@main>
Reviewed commits have been landed. Closing PR #8798 and removing active labels.