Bug 250794

Summary:	[ews-build.webkit.org] Ensure new-style steps correctly using defers
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Jonathan Bedard

Reported 2023-01-18 14:37:14 PST

When using a new-style buildbot step, the run() command will return a defered object. This means that if we're using '@defer.inlineCallbacks', we need to use defer.returnValue instead of returning something.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-01-18 14:37:30 PST

<rdar://problem/104398102>

Jonathan Bedard

Comment 2 2023-01-18 14:41:17 PST

Pull request: https://github.com/WebKit/WebKit/pull/8795

EWS

Comment 3 2023-01-24 07:55:55 PST

Committed 259281@main (29e63587c7cd): <https://commits.webkit.org/259281@main> Reviewed commits have been landed. Closing PR #8795 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.