Bug 250751
| Summary: | Replace uses of CallFrame::iterate() with StackVisitor::visit(). | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
This is blocking the StackVisitor from dumping the JS stack when we encounter Wasm frames. The assertion was from back when Wasm frames didn't exist.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/104363671>
Mark Lam
(In reply to Mark Lam from comment #0)
> This is blocking the StackVisitor from dumping the JS stack when we
> encounter Wasm frames. The assertion was from back when Wasm frames didn't
> exist.
To clarify, I changed the title to reflect the change I'm actually going to make. The assertion in the above comment was from inside CallFrame::iterate(). I ended up doing away with this assertion by removing CallFrame::iterate() altogether.
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/8755
EWS
Committed 259027@main (59c35e231667): <https://commits.webkit.org/259027@main>
Reviewed commits have been landed. Closing PR #8755 and removing active labels.