Bug 250638

Summary:	Remove unused RenderListBox::valueChanged
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Layout and Rendering	Assignee:	Ahmad Saleem <ahmad.saleem792>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, ntim, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-01-15 03:48:49 PST

Hi Team,

While going through Blink's commit, I came across another potential refactoring and simplification:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/bb27fa73c029f6390fbf15a6ffdcb3b146e6181c

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderListBox.cpp#687 & https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderListBox.h#173

Just wanted to get input before I can do PR and remove this as well.

Thanks!

Comment 1 Tim Nguyen (:ntim) 2023-01-15 23:11:58 PST

Seems unused to me, thanks for finding this!

Comment 2 Ahmad Saleem 2023-01-16 02:48:00 PST

PR - https://github.com/WebKit/WebKit/pull/8683

Comment 3 EWS 2023-01-16 08:43:38 PST

Committed 258955@main (c8fd7771b683): <https://commits.webkit.org/258955@main>

Reviewed commits have been landed. Closing PR #8683 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2023-01-16 08:44:15 PST

<rdar://problem/104300763>