Bug 250629
| Summary: | Remove special case for HTMLMediaElement in shouldEventCrossShadowBoundary | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | eric.carlson, karlcow, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, it seems that they remove this code since it was work-around added for VIMEO website:
Original bug - which added this - bug 61717
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/dom/EventPath.cpp#42
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/1e4b0fe0de5ed5e99891932df799a8b000d426c1
Just wanted to raise to get input whether we can safely remove this now.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/104518285>
Eric Carlson
Yes, as long as the issue doesn’t reproduce with the change removed.
Ahmad Saleem
(In reply to Eric Carlson from comment #2)
> Yes, as long as the issue doesn’t reproduce with the change removed.
Just did local build and tried video - https://vimeo.com/336812686
and tried to scrub and see if it does not work etc. as original issue mentioned but seems to work fine.
I will do draft PR and run it through EWS and see if it has any impact.
EWS
Committed 259404@main (bb61af8a5102): <https://commits.webkit.org/259404@main>
Reviewed commits have been landed. Closing PR #9126 and removing active labels.