Bug 250594

Summary:	Let MediaController.currentTime return the position previously set
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Media	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, bfulgham, eric.carlson, jer.noble, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-01-13 14:12:49 PST

Hi Team,

While going through Blink's commit, came across a bug, which is no align with web-spec:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/32276c29774c6af8a4ad9f6d0d6551bf8323883c

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/html/MediaController.cpp#169

'''

The currentTime attribute must, on getting, return the media element's default playback start position, unless that is zero, in which case it must return the element's official playback position. The returned value must be expressed in seconds. On setting, if the media element's readyState is HAVE_NOTHING, then it must set the media element's default playback start position to the new value; otherwise, it must set the official playback position to the new value and then seek to the new value. The new value must be interpreted as being in seconds.

'''

Web-Spec - https://html.spec.whatwg.org/multipage/media.html#offsets-into-the-media-resource

Just wanted to raise to get input, whether we should go ahead and merge this.

Thanks!

Comment 1 Eric Carlson 2023-01-17 06:14:49 PST

I think we should.

Comment 2 Ahmad Saleem 2023-01-17 06:16:25 PST

(In reply to Eric Carlson from comment #1)
> I think we should.

Cool! I will do PR later today and see what happens with EWS. :-)

Comment 3 EWS 2023-01-18 01:23:11 PST

Committed 259020@main (921f8243c150): <https://commits.webkit.org/259020@main>

Reviewed commits have been landed. Closing PR #8740 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2023-01-18 01:24:16 PST

<rdar://problem/104370834>