Bug 250584
| Summary: | [WebRTC] Fix -Wdeprecated-copy warnings in the boringssl project | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebRTC | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 250431 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
Fix -Wdeprecated-copy warnings in the boringssl project:
Source/third_party/boringssl/src/include/openssl/bytestring.h:53:3: error: definition of implicit copy assignment operator for 'cbs_st' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
cbs_st(const cbs_st &) = default;
^
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/t1_lib.cc:183:14: note: in implicit copy assignment operator for 'cbs_st' first required here
extensions = *cbs;
^
Source/third_party/boringssl/src/include/openssl/bytestring.h:53:3: error: definition of implicit copy assignment operator for 'cbs_st' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
cbs_st(const cbs_st &) = default;
^
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/handshake_server.cc:452:18: note: in implicit copy assignment operator for 'cbs_st' first required here
extensions = copy;
^
Source/third_party/boringssl/src/include/openssl/bytestring.h:53:3: error: definition of implicit copy assignment operator for 'cbs_st' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
cbs_st(const cbs_st &) = default;
^
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/ssl/handshake.cc:176:18: note: in implicit copy assignment operator for 'cbs_st' first required here
out_msg->raw = CBS(ech_client_hello_buf);
^
Fixed by upstream commit:
Fix a -Wdeprecated-copy warning.
https://github.com/google/boringssl/commit/f315a86df3d5cd51135db996c9d5747ec2641331
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/104231355>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/8631
EWS
Committed 258907@main (ade6fee2858e): <https://commits.webkit.org/258907@main>
Reviewed commits have been landed. Closing PR #8631 and removing active labels.