Bug 250524

Summary:	Fix nit which is inefficient sequence to deleteMarkedNodes
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Web Audio	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, jer.noble, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-01-12 13:15:57 PST

Hi Team,

While going through Blink's commit, I think we can fix inefficient sequence as well:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/ec81c8eb26580fce076c096c13463d754f40e6c3

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp#179

Move this below:

m_nodesToDelete = std::exchange(m_nodesMarkedForDeletion, { });
---> here

Just wanted to raise so we can fix this.

Thanks!

Comment 1 EWS 2023-01-14 11:53:25 PST

Committed 258920@main (6eceb6d922f3): <https://commits.webkit.org/258920@main>

Reviewed commits have been landed. Closing PR #8590 and removing active labels.

Comment 2 Radar WebKit Bug Importer 2023-01-14 11:54:17 PST

<rdar://problem/104263455>