Bug 250503

Summary:

AX: Remove obsolete comment in AXIsolatedTree::updateChildren regarding subtree removals

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tyler Wilcock 2023-01-11 23:01:44 PST

This comment in AXIsolatedTree::updateChildren:

https://github.com/WebKit/WebKit/blob/65cbbd06b50bb3c8e45aabd0c47322e540baf4fd/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp#L609#L613

Was obsoleted by this commit:

https://github.com/WebKit/WebKit/commit/755fc266ed7bbbbcd5505c9e842d89caf9796c19

Because the referenced variable (`idsBeingChanged`) was obsoleted by checking m_unresolvedPendingAppends in AXIsolatedTree::removeSubtreeFromNodeMap (which accomplishes the same thing).

Comment 1 Radar WebKit Bug Importer 2023-01-11 23:01:55 PST

<rdar://problem/104156450>

Comment 2 Tyler Wilcock 2023-01-11 23:08:11 PST

Created attachment 464467 [details]
Patch

Comment 3 EWS 2023-01-12 10:39:39 PST

Committed 258839@main (88766c1ad26b): <https://commits.webkit.org/258839@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464467 [details].