Bug 250481
| Summary: | Improve comparison of intervals in SVGSMILElement::resolveFirstInterval | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | karlcow, sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, came across another potential fix:
Commit - https://src.chromium.org/viewvc/blink?revision=175122&view=revision
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/svg/animation/SVGSMILElement.cpp#863 etc.
Just wanted to raise to see if we can fix this.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
The prose of the Blink commit.
============
Improve comparison of intervals in SVGSMILElement::resolveFirstInterval
For open-ended intervals such as [3) - i.e. begin=3s and end/duration/etc
unspecified - every call to resolveFirstInterval() would think that a new
interval had been created, and notify/require a reschedule of the
animations.
Add a new type SMILInterval and a suitable operator for that, and then
use it to compare the raw values (i.e. if both endpoints are exacly the same.)
BUG=377329
===========
https://bugs.chromium.org/p/chromium/issues/detail?id=377329
There is a testcase in there.
Ahmad Saleem
(In reply to Karl Dubost from comment #1)
> The prose of the Blink commit.
>
> ============
> Improve comparison of intervals in SVGSMILElement::resolveFirstInterval
>
> For open-ended intervals such as [3) - i.e. begin=3s and end/duration/etc
> unspecified - every call to resolveFirstInterval() would think that a new
> interval had been created, and notify/require a reschedule of the
> animations.
> Add a new type SMILInterval and a suitable operator for that, and then
> use it to compare the raw values (i.e. if both endpoints are exacly the
> same.)
>
> BUG=377329
> ===========
> https://bugs.chromium.org/p/chromium/issues/detail?id=377329
>
>
> There is a testcase in there.
The test need:
Add a printf in SVGImageChromeClient::invalidateContentsAndRootView
Radar WebKit Bug Importer
<rdar://problem/104399900>
Ahmad Saleem
SVN repo is gone - so alternative link - https://github.com/chromium/chromium/commit/5b93bdd34c17dae682ce14c45125abc603310b16
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/49818
EWS
Committed 299110@main (661903c79498): <https://commits.webkit.org/299110@main>
Reviewed commits have been landed. Closing PR #49818 and removing active labels.