Bug 250476

Summary:	Rename createImageBitMaps's imageOrientation from "none" to "from-image"
Product:	WebKit	Reporter:	Yi Xu <yiyix>
Component:	Canvas	Assignee:	Matt Woodrow <mattwoodrow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dino, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari 16
Hardware:	All
OS:	All

Description Yi Xu 2023-01-11 14:40:01 PST

createImageBitMaps's imageOrientation currently has 2 values: "none" and "flipY", where 'none' is used for use the orientation from image. This contradicts from CSS spec, where imageorientation has 3 values: "none", "flipY" and "from-image" and "none" means render the image as coded, no orientation applied.

Rename none to from-image, then update the meaning of none to match what CSS has.

Reference:
whatwg spec: https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html#dom-imagebitmapoptions-imageorientation

CSS spec: https://www.w3.org/TR/css-images-3/#the-image-orientation

github issue: https://github.com/whatwg/html/issues/8085

Comment 1 Radar WebKit Bug Importer 2023-01-18 14:40:25 PST

<rdar://problem/104398244>

Comment 2 Matt Woodrow 2023-08-09 18:26:14 PDT

Pull request: https://github.com/WebKit/WebKit/pull/16546

Comment 3 EWS 2023-08-14 19:45:10 PDT

Committed 266893@main (556e20c0b005): <https://commits.webkit.org/266893@main>

Reviewed commits have been landed. Closing PR #16546 and removing active labels.