Bug 250462

Summary: Move transformationForTextBox() call out of the fragment-loop
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   

Ahmad Saleem
Reported 2023-01-11 09:44:43 PST
Hi Team, While going through Blink's commit, I came across another refactoring: Blink Commit - https://src.chromium.org/viewvc/blink?revision=177517&view=revision WebKit Source - https://github.com/WebKit/WebKit/blob/fee955ee6904a3764cbb38e260690dbc4de71338/Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp#L280 It does not have any test case, just wanted to get input whether it is worth doing this refactoring. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
EWS
Comment 1 2023-01-13 12:38:30 PST
Committed 258886@main (e1696eb5587f): <https://commits.webkit.org/258886@main> Reviewed commits have been landed. Closing PR #8570 and removing active labels.
Radar WebKit Bug Importer
Comment 2 2023-01-13 12:40:19 PST
<rdar://problem/104235971>
Note You need to log in before you can comment on or make changes to this bug.