Bug 250431

Summary: Start extracting common WARNING_CFLAGS into CommonBase.xcconfig
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, emw, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 250576, 250584, 250622    

Description David Kilzer (:ddkilzer) 2023-01-10 18:07:21 PST 
Start extracting common WARNING_CFLAGS into Configurations/CommonBase.xcconfig.

The goal here is to make it possible to add a new warning flag for all projects by changing one file.

It's a non-goal to extract every single warning flag with this initial patch--just start the process to make it easy for others to contribute.
Comment 1 Radar WebKit Bug Importer 2023-01-10 18:07:42 PST 
<rdar://problem/104102992>
Comment 2 David Kilzer (:ddkilzer) 2023-01-10 18:07:48 PST 
In the process of writing this patch, I found a couple of interesting issues:

1. The ANGLE (Dynamic) target has been building without -Werror (e.g., with -Wno-error instead) since 2021-12-07 due to a regression in 244928@main.

This issue is fixed by the PR that will be posted by building with -Werror again, and temporarily ignoring the warnings that regressed in the last year by documenting them.

2. The libwebrtc project has a number of warnings that other projects don't have (since it wasn't setting as many warning flags when building prior to this patch).

This issue is worked around by temporarily ignoring the warnings and by documenting them.
Comment 3 David Kilzer (:ddkilzer) 2023-01-10 18:23:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8503
Comment 4 EWS 2023-01-12 15:23:12 PST 
Committed 258855@main (2a6683c96f6b): <https://commits.webkit.org/258855@main>

Reviewed commits have been landed. Closing PR #8503 and removing active labels.