Bug 250334

Summary: REGRESSION(258522@main): Ensure the slider style is applied to an <input> element before drawing
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 249168    

Description Said Abou-Hallawa 2023-01-09 12:13:48 PST
The appearance style can be applied to any non <input> element like this this one:

<style>
  html {
    appearance: slider-vertical;
  }
</style>

In 258522@main createSliderTrackPartForRenderer() was refactored from RenderTheme::paintSliderTicks() which makes an early return "if (!is<HTMLInputElement>(o.node()))". We need to port this check to createSliderTrackPartForRenderer().
Comment 1 Said Abou-Hallawa 2023-01-09 12:14:19 PST
rdar://104019874
Comment 2 Said Abou-Hallawa 2023-01-09 12:19:02 PST
Pull request: https://github.com/WebKit/WebKit/pull/8411
Comment 3 EWS 2023-01-09 14:35:15 PST
Committed 258684@main (c14ea6ce8716): <https://commits.webkit.org/258684@main>

Reviewed commits have been landed. Closing PR #8411 and removing active labels.