Bug 250282
| Summary: | [Multicolumn] Guard against zero or negative space shortage | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, ntim, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
Just going through Blink's commit, which would be good to add:
Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=174088
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderMultiColumnFlow.cpp#185
Adding following early return (by following WebKit Coding Style - https://webkit.org/code-style-guidelines/#null-false-and-zero):
if (!spaceShortage)
return;
___
Just wanted to raise so this can be fixed for any potential debug issue. I also checked that we never imported these blink test cases etc.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
> Adding following early return (by following WebKit Coding Style - https://webkit.org/code-style-guidelines/#null-false-and-zero):
> if (!spaceShortage)
> return;
(Note that negative values are truthy, so `spaceShortage <= 0` is correct)
Ahmad Saleem
PR - https://github.com/WebKit/WebKit/pull/8373
alan
(In reply to Tim Nguyen (:ntim) from comment #1)
> > Adding following early return (by following WebKit Coding Style - https://webkit.org/code-style-guidelines/#null-false-and-zero):
>
> > if (!spaceShortage)
> > return;
>
> (Note that negative values are truthy, so `spaceShortage <= 0` is correct)
truth!
EWS
Committed 258647@main (783df4eb9096): <https://commits.webkit.org/258647@main>
Reviewed commits have been landed. Closing PR #8373 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/104011828>