Bug 250276

Summary: Adjust error-handling for invalid filter primitive references
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar, LayerBasedSVGEngine
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2023-01-07 10:09:56 PST 
Hi Team,

While going through Blink's commit, I came across another failing test case:

Test Case - https://jsfiddle.net/xothm1vc/show

^ Safari 16.2 & STP160 only show two green rectangles. While Firefox Nightly 110 and Chrome Canary 111 show full green bar rectangle, not just two slots.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/ffa39ae78904542a2864e2cb7d1c16c24ee2324e

I haven't checked whether it is 1-1 merge or not but just wanted to raise for tracking.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-01-14 10:10:15 PST 
<rdar://problem/104262208>
Comment 2 Ahmad Saleem 2023-05-07 04:17:26 PDT 
WebKit ToT (263769@main) get full bar but half is 'red' while STP169 still shows only two rectangles.

Just wanted to highlight small-progression.
Comment 3 Ahmad Saleem 2023-05-07 04:19:39 PDT 
This commit removed 'SVGFilterBuilder.cpp' in WebKit - https://commits.webkit.org/251522@main
Comment 4 Ahmad Saleem 2023-05-08 02:29:16 PDT 
(In reply to Ahmad Saleem from comment #2)
> WebKit ToT (263769@main) get full bar but half is 'red' while STP169 still
> shows only two rectangles.
> 
> Just wanted to highlight small-progression.

This is with LBSE turned on.

LBSE off is still same.
Comment 6 Ahmad Saleem 2024-05-08 16:38:21 PDT 
This compiles and fixes this test case:

    RefPtr<NodeType> getNamedNode(const AtomString& id) const
    {
        if (!id.isEmpty()) {
            if (m_sourceNodes.contains(id))
                return m_sourceNodes.get(id);
            
            if (m_namedNodes.contains(id))
                return m_namedNodes.get(id);
        }

        if (m_lastNode)
            return m_lastNode;

        return sourceGraphic();
    }

in https://searchfox.org/wubkat/rev/7bf250e4832adfb28c2bf2bc518ad59958f2ae1b/Source/WebCore/svg/graphics/filters/SVGFilterGraph.h#78

For LBSE - there isn't any improvement or regression.
Comment 7 EWS 2024-05-28 19:38:17 PDT 
Committed 279421@main (8e028375b9c5): <https://commits.webkit.org/279421@main>

Reviewed commits have been landed. Closing PR #28314 and removing active labels.