Bug 250274

Summary:	Remove incorrect FIXME about HTMLPreElement.width type
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	DOM	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	akeerthi, ap, bfulgham, karlcow, ntim, rniwa, webkit-bug-importer
Priority:	P2	Keywords:	GoodFirstBug, InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=8992

Description Ahmad Saleem 2023-01-07 08:24:23 PST

Hi Team,

While going through other change, I came across FIXME and noticed that all browser (Safari 16.2, Chrome Canary 111 and Firefox Nightly 110) are showing 'width' as "Number" rather than "String".

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLPreElement.idl#27

Test Case - https://bug-8992-attachments.webkit.org/attachment.cgi?id=8403

I think we can get rid of it since now all browsers are matching, appreciate someone can confirm.

Thanks!

Comment 1 Karl Dubost 2023-01-11 17:48:16 PST

Chromium
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/html_pre_element.idl;l=25;drc=5b8bfc413800d2246a7a58b7d86c78f590c7811b

Firefox
https://searchfox.org/mozilla-central/rev/fb9a504ca73529fa550efe488db2a012a4bf5169/dom/webidl/HTMLPreElement.webidl#16

Do you mean to remove the FIXME comment. Yes it's possible, you could replace by a comment link to the spec the same way Firefox and Chrome do.

Comment 2 EWS 2023-01-12 10:31:06 PST

Committed 258838@main (a37a7d6fcf2a): <https://commits.webkit.org/258838@main>

Reviewed commits have been landed. Closing PR #8581 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-01-12 10:32:18 PST

<rdar://problem/104184589>