Bug 250100

Summary:	use an alpha-less pixel format for 32 bit IOSurfaces when RemoteLayerBackingStore::Parameters::isOpaque is true
Product:	WebKit	Reporter:	Cameron McCormack (:heycam) <heycam>
Component:	Layout and Rendering	Assignee:	Cameron McCormack (:heycam) <heycam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, rackler, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=250243

Description Cameron McCormack (:heycam) 2023-01-04 13:02:56 PST

We currently use PixelFormat::BGRA8, which means we miss out on some accelerated drawing optimizations in CoreAnimation.

Comment 1 Radar WebKit Bug Importer 2023-01-04 13:03:18 PST

<rdar://problem/103885395>

Comment 2 Cameron McCormack (:heycam) 2023-01-05 16:35:11 PST

Pull request: https://github.com/WebKit/WebKit/pull/8265

Comment 3 EWS 2023-01-05 20:03:17 PST

Committed 258523@main (031263226f11): <https://commits.webkit.org/258523@main>

Reviewed commits have been landed. Closing PR #8265 and removing active labels.

Comment 4 Karl Rackler 2023-01-06 16:47:36 PST

Reverted by https://github.com/WebKit/WebKit/pull/8335

Comment 5 EWS 2023-01-06 16:50:29 PST

Committed 258583@main (871170dff040): <https://commits.webkit.org/258583@main>

Reviewed commits have been landed. Closing PR #8335 and removing active labels.

Comment 6 Karl Rackler 2023-01-06 17:04:40 PST

Description:
This change caused the following two tests to consistently crash.

imported/w3c/web-platform-tests/webrtc-encoded-transform/script-change-transform.https.html
imported/w3c/web-platform-tests/webrtc/protocol/h264-profile-levels.https.html

Comment 7 Alexey Proskuryakov 2023-01-07 11:17:12 PST

This was reverted in https://commits.webkit.org/258583@main

Comment 8 Cameron McCormack (:heycam) 2023-01-08 20:23:05 PST

Pull request: https://github.com/WebKit/WebKit/pull/8386

Comment 9 EWS 2023-01-09 02:33:09 PST

Committed 258654@main (bd8e9982ce3e): <https://commits.webkit.org/258654@main>

Reviewed commits have been landed. Closing PR #8386 and removing active labels.