Bug 250099

Summary:

AX: Conversion of PDFView coordinates to screen coordinates for accessibility should happen on the main thread.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andresg_22, cfleizach, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Andres Gonzalez

Reported 2023-01-04 12:46:18 PST

Failing to do so causes random crashes like: rdar://103835507

Attachments
Patch (7.00 KB, patch) 2023-01-04 12:50 PST, Andres Gonzalez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-01-04 12:46:31 PST

<rdar://problem/103884859>

Andres Gonzalez

Comment 2 2023-01-04 12:50:18 PST

Created attachment 464335 [details] Patch

chris fleizach

Comment 3 2023-01-04 12:59:23 PST

Comment on attachment 464335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464335&action=review > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2009 > + return page->chrome().rootViewToScreen(enclosingIntRect(updatedRect)); return page ? page->chrome().rootViewToScreen(enclosingIntRect(updatedRect)); : { }; > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2025 > + return page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates)); return page ? page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates)) : { };

Andres Gonzalez

Comment 4 2023-01-04 13:13:17 PST

(In reply to chris fleizach from comment #3) > Comment on attachment 464335 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=464335&action=review > > > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2009 > > + return page->chrome().rootViewToScreen(enclosingIntRect(updatedRect)); > > return page ? > page->chrome().rootViewToScreen(enclosingIntRect(updatedRect)); : { }; > > > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2025 > > + return page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates)); > > return page ? > page->chrome().rootViewToScreen(enclosingIntRect(rectInRootViewCoordinates)) > : { }; Unfortunately you can't have an initializer list in a ? : statement. So you would need to do something like ... ? ... : FloatRect(), which is kind of ugly too. Hopefully, in C++ 26 they got that in :-).

EWS

Comment 5 2023-01-04 20:00:09 PST

Committed 258469@main (c7cf1700de11): <https://commits.webkit.org/258469@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464335 [details].

Note You need to log in before you can comment on or make changes to this bug.