Bug 249875

Summary: AX: indeterminate progress elements are not reported as indeterminate by VoiceOver
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Tyler Wilcock 2022-12-24 19:26:49 PST 
AX: indeterminate progress elements are not reported as indeterminate by VoiceOver
Comment 1 Radar WebKit Bug Importer 2022-12-24 19:27:00 PST 
<rdar://problem/103690774>
Comment 2 Tyler Wilcock 2022-12-24 19:42:20 PST 
Created attachment 464199 [details]
Patch
Comment 3 Tyler Wilcock 2022-12-24 20:00:36 PST 
Created attachment 464201 [details]
Patch
Comment 4 chris fleizach 2022-12-24 21:38:27 PST 
Comment on attachment 464201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464201&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1919
> +        return [NSNumber numberWithBool: backingObject->isIndeterminate()];

Space after : nit
Comment 5 chris fleizach 2022-12-24 23:21:51 PST 
Comment on attachment 464201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464201&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1908
> +- (id)_accessibilityAttributeValueForTesting:(NSString *)attributeName

why can't we use the normal interfaces for testing this? seems like we'd want to check the same thing the platform code will use
Comment 6 Tyler Wilcock 2022-12-25 09:04:10 PST 
Created attachment 464206 [details]
Patch
Comment 7 Tyler Wilcock 2022-12-25 09:05:23 PST 
(In reply to chris fleizach from comment #5)
> Comment on attachment 464201 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464201&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1908
> > +- (id)_accessibilityAttributeValueForTesting:(NSString *)attributeName
> 
> why can't we use the normal interfaces for testing this? seems like we'd
> want to check the same thing the platform code will use
OK, removed _accessibilityAttributeValueForTesting and moved handling of the attribute to the normal accessibilityAttributeValue interface.
Comment 8 Tyler Wilcock 2022-12-25 14:14:20 PST 
Created attachment 464210 [details]
Patch
Comment 9 EWS 2022-12-25 17:51:01 PST 
Committed 258332@main (ece8b0ebf62d): <https://commits.webkit.org/258332@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464210 [details].