| Summary: | Add --max-bundle-size switch to generate-unified-source-bundles.rb | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
| Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, annulen, don.olmstead, ews-watchlist, gyuyoung.kim, pvollan, ryuan.choi, sergio, stephan.szabo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=237617 | ||||||
| Attachments: |
|
||||||
|
Description
Fujii Hironori
2022-12-22 12:12:24 PST
It seems to be caused by unified source build. 248190@main (bug#237617) changed MAX_BUNDLE_SIZE to 16 for Windows to fix WinCairo.lib linkage problem. However, WinCairo no longer has WinCairo.lib, but WinCairo.dll since 257608@main. Should WinCairo reduce `MAX_BUNDLE_SIZE` to 8? not so frequently, but it's still happening. https://ews-build.webkit.org/#/builders/12/builds/109107 Created attachment 464341 [details]
Patch
Comment on attachment 464341 [details]
Patch
I don't know much about the details of the bundling, but that seems reasonable to only use the larger value for the static webcore builds.
Committed 258502@main (b30c9488d235): <https://commits.webkit.org/258502@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464341 [details]. I haven't observed WinCairo-EWS's "compiler is out of heap space" problem after the change. But, I've observed about 20% build speed down after that. 😥 It happens again. Both WebCore and WebKit modules in this time. https://ews-build.webkit.org/#/builders/12/builds/120965 > FAILED: Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-35.cpp.obj https://ews-build.webkit.org/#/builders/12/builds/120930 > FAILED: Source/WebKit/CMakeFiles/WebKit.dir/__/__/WebKit/DerivedSources/unified-sources/UnifiedSource-54928a2b-26.cpp.obj |