Bug 249705

Summary: Potential Assertion Fix in Multicolumn - Give up on stretching columns if they have already reached max height
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2022-12-21 03:38:03 PST 
Hi Team,

While going through Blink, I came across another potential assertion fix, which can make Webkit's layout and rendering more robust.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=192636

Webkit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderMultiColumnSet.cpp#245

___

if (m_computedColumnHeight >= m_maxColumnHeight) {

// comments

return m_computedColumnHeight;
}

___

Just wanted to raise this bug so we can also add this fix.

Thanks!
Comment 1 EWS 2022-12-21 19:07:13 PST 
Committed 258230@main (3edf242b588b): <https://commits.webkit.org/258230@main>

Reviewed commits have been landed. Closing PR #7953 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2022-12-21 19:08:17 PST 
<rdar://problem/103622112>