Bug 249685

Summary: [CSS-Typed-OM] StylePropertyMap.set() should throw when trying to set a number for a property which doesn't allow it
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175733    

Chris Dumez
Reported 2022-12-20 16:41:30 PST
StylePropertyMap.set() should throw when trying to set a number for a property which doesn't allow it. We previously relied on our CSS parser for validation. However, CSS parsing is more permissive than CSS Typed OM is some cases. In particular, the CSS parser will append "px" to numbers in some cases for properties that need a <length>. For CSS Typed OM, the type needs to match exactly: - https://drafts.css-houdini.org/css-typed-om-1/#cssstylevalue-match-a-grammar
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-12-20 16:47:08 PST
Pull request: https://github.com/WebKit/WebKit/pull/7945
EWS
Comment 2 2022-12-22 07:52:44 PST
Committed 258242@main (add3c9105b58): <https://commits.webkit.org/258242@main> Reviewed commits have been landed. Closing PR #7945 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-12-22 07:53:15 PST
<rdar://problem/103638252>
Note You need to log in before you can comment on or make changes to this bug.