Bug 249612
| Summary: | Fix issue where WebAuth timeouts lead to an incorrect error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Charlie Wolfe <charliew> |
| Component: | WebKit Misc. | Assignee: | Charlie Wolfe <charliew> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | jenner, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Charlie Wolfe
When an auth prompt times out it leads to an HierarchyRequestError, which is incorrect.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Charlie Wolfe
rdar://100825830
Charlie Wolfe
Pull request: https://github.com/WebKit/WebKit/pull/7879
EWS
Committed 258116@main (56aa37f2fb91): <https://commits.webkit.org/258116@main>
Reviewed commits have been landed. Closing PR #7879 and removing active labels.
Robert Jenner
It appears that this commit broke the following two API tests for iOS:
TestWebKitAPI.WebAuthenticationPanel.GetAssertionCrossPlatform
TestWebKitAPI.WebAuthenticationPanel.GetAssertionSPITimeout
HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebAuthenticationPanel.GetAssertionCrossPlatform&test=TestWebKitAPI.WebAuthenticationPanel.GetAssertionSPITimeout
I have confirmed that the regression point was 258116@main because the tests fail at that commit, but pass at the commit directly before it.