Bug 249612

Summary:	Fix issue where WebAuth timeouts lead to an incorrect error
Product:	WebKit	Reporter:	Charlie Wolfe <charliew>
Component:	WebKit Misc.	Assignee:	Charlie Wolfe <charliew>
Status:	REOPENED ---
Severity:	Normal	CC:	jenner, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Charlie Wolfe 2022-12-19 15:28:42 PST

When an auth prompt times out it leads to an HierarchyRequestError, which is incorrect.

Comment 1 Charlie Wolfe 2022-12-19 15:29:10 PST

rdar://100825830

Comment 2 Charlie Wolfe 2022-12-19 15:36:06 PST

Pull request: https://github.com/WebKit/WebKit/pull/7879

Comment 3 EWS 2022-12-19 18:31:18 PST

Committed 258116@main (56aa37f2fb91): <https://commits.webkit.org/258116@main>

Reviewed commits have been landed. Closing PR #7879 and removing active labels.

Comment 4 Robert Jenner 2022-12-20 11:20:29 PST

It appears that this commit broke the following two API tests for iOS:

TestWebKitAPI.WebAuthenticationPanel.GetAssertionCrossPlatform
TestWebKitAPI.WebAuthenticationPanel.GetAssertionSPITimeout

HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebAuthenticationPanel.GetAssertionCrossPlatform&test=TestWebKitAPI.WebAuthenticationPanel.GetAssertionSPITimeout

I have confirmed that the regression point was 258116@main because the tests fail at that commit, but pass at the commit directly before it.