Bug 249580

Summary:	Evaluate string::adopt function usage and if it can be now removed
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	darin, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2022-12-19 08:55:34 PST

Hi,

This bug is based on @Darin's comment on PR7827:

https://github.com/WebKit/WebKit/pull/7827#pullrequestreview-1222082977

It is following:

'If this eliminates all uses of the String::adopt function that takes a vector, then that function should also be removed from the String class.'

Quick search shows that it is currently used across various files:


Source/WTF/wtf/URLParser.cpp
Source/WebCore/platform/text/LocaleICU.cpp <--- PR was modifying this file
Source/WTF/wtf/URLHelpers.cpp
Source/WebCore/PAL/pal/text/win/TextCodecWin.cpp
Source/JavaScriptCore/runtime/JSDateMath.cpp
Source/WebKit/UIProcess/Inspector/Mac/RemoteWebInspectorUIProxyMac.mm
...

Just wanted to raise this to get input and also to track it for future purposes.

Thanks!

Comment 1 Radar WebKit Bug Importer 2022-12-26 08:56:15 PST

<rdar://problem/103711236>