Bug 249569

Summary:	Notify networking stack that download is media related
Product:	WebKit	Reporter:	Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component:	Media	Assignee:	Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	commit-queue, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=250420 https://bugs.webkit.org/show_bug.cgi?id=253996
Bug Depends on:	249728, 249815
Bug Blocks:

Description Jean-Yves Avenard [:jya] 2022-12-18 21:48:29 PST

Emit system notification that a download is media related.

Comment 1 Jean-Yves Avenard [:jya] 2022-12-18 21:48:47 PST

rdar://103046339

Comment 2 Jean-Yves Avenard [:jya] 2022-12-19 00:15:46 PST

Pull request: https://github.com/WebKit/WebKit/pull/7840

Comment 3 EWS 2022-12-21 04:07:45 PST

Committed 258185@main (bb01ed69cdd9): <https://commits.webkit.org/258185@main>

Reviewed commits have been landed. Closing PR #7840 and removing active labels.

Comment 4 WebKit Commit Bot 2022-12-21 10:27:37 PST

Re-opened since this is blocked by bug 249728

Comment 5 Ryan Haddad 2022-12-21 10:28:36 PST

The API test added with this change is consistently failing
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.MSEHasMediaStreamingActivity

    TestWebKitAPI.WebKit.MSEHasMediaStreamingActivity
        
        /Volumes/Data/worker/Apple-Monterey-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm:64
        Value of: isMediaStreamingChanged
          Actual: false
        Expected: true
        
        
        /Volumes/Data/worker/Apple-Monterey-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm:65
        Value of: isMediaStreaming
          Actual: false
        Expected: true
        
        
        /Volumes/Data/worker/Apple-Monterey-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm:69
        Value of: isMediaStreamingChanged
          Actual: false
        Expected: true

Comment 6 Ryan Haddad 2022-12-21 10:35:21 PST

Reverted in https://commits.webkit.org/258200@main

Comment 7 Jean-Yves Avenard [:jya] 2022-12-21 16:38:13 PST

Pull request: https://github.com/WebKit/WebKit/pull/7990

Comment 8 EWS 2022-12-21 19:41:12 PST

Committed 258232@main (3b0ed39e4c4b): <https://commits.webkit.org/258232@main>

Reviewed commits have been landed. Closing PR #7990 and removing active labels.

Comment 9 WebKit Commit Bot 2022-12-22 14:44:10 PST

Re-opened since this is blocked by bug 249815

Comment 10 Ryan Haddad 2022-12-22 14:48:30 PST

Reverted in https://commits.webkit.org/258262@main because the API test is timing out on iOS simulator.

Comment 11 Jean-Yves Avenard [:jya] 2023-01-09 02:01:53 PST

Pull request: https://github.com/WebKit/WebKit/pull/8390

Comment 12 EWS 2023-01-10 19:17:52 PST

Committed 258765@main (127556767fd6): <https://commits.webkit.org/258765@main>

Reviewed commits have been landed. Closing PR #8390 and removing active labels.