Bug 249458

Summary: [GTK] [2.39.3] Non-unified builds broken
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Alberto Garcia <berto>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review+, mcatanzaro: commit-queue-

Alberto Garcia
Reported 2022-12-16 01:07:33 PST
Created attachment 464070 [details] Patch The patch is against main but it applies cleanly except for CSSPropertySyntax.cpp which was recently renamed.
Attachments
Patch (14.40 KB, patch)
2022-12-16 01:07 PST, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Patch (13.97 KB, patch)
2022-12-16 03:45 PST, Alberto Garcia 		mcatanzaro: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2022-12-16 03:45:26 PST
Created attachment 464075 [details] Patch Sorry, the previous patch had style errors, here's the updated one
Michael Catanzaro
Comment 2 2022-12-16 06:37:48 PST
Comment on attachment 464075 [details] Patch Hi Berto, can you please add the COMMIT_MESSAGE following the usual template? Then we won't have to modify the patch for you.
Alberto Garcia
Comment 3 2022-12-16 10:46:37 PST
Pull request: https://github.com/WebKit/WebKit/pull/7761
Alberto Garcia
Comment 4 2022-12-16 10:47:05 PST
I had to update the patch after the latest changes in main, now with a pull request
EWS
Comment 5 2022-12-16 12:30:45 PST
Committed 258011@main (cc4248a1c61e): <https://commits.webkit.org/258011@main> Reviewed commits have been landed. Closing PR #7761 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.