Bug 249340

Summary: [ews] Optimization to reduce number of results database lookups
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   

Description Aakash Jain 2022-12-14 14:46:06 PST 
When there are lot of test failures, we consult results db for every failure. However, we can bypass the retry logic only if ALL the test failures are pre-existing. If even one failure is not pre-existing, we can't benefit from results database lookups. So, we can optimize the number of results database calls, by skipping consulting results-db for further tests the moment we know that one of the test failure is not pre-existing.

Number of test failures (and resulting number of results db calls) can be lot for some queues, e.g.: 170 on GTK-WK2-Tests-EWS queue in https://ews-build.webkit.org/#/builders/35/builds/34489/steps/23/logs/test-failures . Even on mac/ios queue it can be upto 60 failures (after https://commits.webkit.org/257442@main). So this change would help reduce unnecessary results database calls in those cases.
Comment 1 Radar WebKit Bug Importer 2022-12-14 14:47:56 PST 
<rdar://problem/103373814>
Comment 2 Aakash Jain 2022-12-14 14:49:11 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7642
Comment 3 EWS 2022-12-14 15:27:54 PST 
Committed 257881@main (d57630c96a63): <https://commits.webkit.org/257881@main>

Reviewed commits have been landed. Closing PR #7642 and removing active labels.