Bug 249338

Summary:	run-benchmark should not limit profile collection to macOS platforms
Product:	WebKit	Reporter:	hysu <hysu>
Component:	Tools / Tests	Assignee:	hysu <hysu>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	hysu, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

hysu

Reported 2022-12-14 14:26:39 PST

Running browser benchmarks through run-benchmark should not limit profile collection (--profile) to macOS platforms. It may also be preferable to break the generated profile filename into directory and filename components, to avoid assumptions as to where the final profile will end up.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-12-14 14:27:02 PST

<rdar://problem/103372861>

hysu

Comment 2 2022-12-14 15:19:45 PST

Pull request: https://github.com/WebKit/WebKit/pull/7643

EWS

Comment 3 2022-12-19 17:00:07 PST

Committed 258109@main (b5a473c9f6d7): <https://commits.webkit.org/258109@main> Reviewed commits have been landed. Closing PR #7643 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.