Bug 249207

Summary:	[margin-trim] Implement margin trims for floats within block containers that establish block formatting context
Product:	WebKit	Reporter:	Sammy Gill <sgill26>
Component:	Layout and Rendering	Assignee:	Sammy Gill <sgill26>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Sammy Gill 2022-12-12 22:28:10 PST

It also affects floats for which the block container is a containing block by:

- Discarding the block-start margin of any float whose block-start outer edge coincides with the block-start inner edge of the container.
- Discarding the inline-start/inline-end margin of an inline-start/inline-end float (or equivalent) whose outer edge on that side coincides with the inner edge of the container.
- Zeroing the inline-axis margins of a float for the purpose of calculating its intrinsic size contributions or its size in the container’s inline axis.
- Trimming the block-end margins of a float to the extent necessary to prevent such a margin from extending the block size of a block formatting context root.

https://w3c.github.io/csswg-drafts/css-box-4/#margin-trim-block

Comment 1 Radar WebKit Bug Importer 2022-12-12 22:29:45 PST

<rdar://problem/103285803>

Comment 2 Sammy Gill 2023-01-24 22:27:51 PST

Pull request: https://github.com/WebKit/WebKit/pull/8910

Comment 3 Sammy Gill 2023-01-25 16:48:18 PST

Pull request: https://github.com/WebKit/WebKit/pull/9145

Comment 4 EWS 2023-02-15 10:29:05 PST

Committed 260318@main (f679766e27a1): <https://commits.webkit.org/260318@main>

Reviewed commits have been landed. Closing PR #8910 and removing active labels.