Bug 249194

Summary:	Floats on an empty line should still get positioned
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2022-12-12 16:53:37 PST

Hi Team,

While going through Blink's commit, I came across another failing test case (from set of two tests), it is failing in Safari 16.1, STP 159 and Firefox Nightly 109, while only Chrome Canary 110 is passing it.

Test Case - https://jsfiddle.net/ztmf9k2g/

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/52a70a867a9bb674c261dfe9e69c7fe4feb47adc

Just wanted to raise this bug so it can be tracked and if possible to be merged.

Thanks!

Comment 1 Ahmad Saleem 2022-12-13 16:06:01 PST

https://github.com/WebKit/WebKit/blob/403e78eb6ddb81c1319cca7045b09199474573ed/Source/WebCore/rendering/LegacyLineLayout.cpp#L1363

&

https://github.com/WebKit/WebKit/blob/403e78eb6ddb81c1319cca7045b09199474573ed/Source/WebCore/rendering/LegacyLineLayout.cpp#L1517

&

https://github.com/WebKit/WebKit/blob/403e78eb6ddb81c1319cca7045b09199474573ed/Source/WebCore/rendering/LegacyLineLayout.cpp#L1872

&

https://github.com/WebKit/WebKit/blob/403e78eb6ddb81c1319cca7045b09199474573ed/Source/WebCore/rendering/LegacyLineLayout.cpp#L1905

&

https://github.com/WebKit/WebKit/blob/403e78eb6ddb81c1319cca7045b09199474573ed/Source/WebCore/rendering/LegacyLineLayout.cpp#L1945

_____

@Alan - should we fix this in Legacy Line Layout since you are working on IFC and this might be fixed in trunk already. Just wanted to get your opinion. Thanks!

Comment 2 zalan 2022-12-15 19:26:11 PST

Yeah, I think we are good. This is not asserting anymore in WebKit.

Comment 3 Radar WebKit Bug Importer 2022-12-19 16:54:18 PST

<rdar://problem/103536598>

Comment 4 Ahmad Saleem 2023-03-03 01:45:46 PST

We are now passing this on WebKit Trunk (261124@main). Just wanted to raise.

Appreciate if someone else can also confirm and then we can close this bug. It might be due to Sammy Rendering related fixes or Alan’s Partial Layout fixes.

Comment 5 zalan 2023-03-04 07:01:51 PST

(In reply to Ahmad Saleem from comment #4)
> We are now passing this on WebKit Trunk (261124@main). Just wanted to raise.
> 
> Appreciate if someone else can also confirm and then we can close this bug.
> It might be due to Sammy Rendering related fixes or Alan’s Partial Layout
> fixes.
I don't think there's been any work done in this area recently.
This bugs is about the float not being placed (ASSERT) which does not reproduce anymore (for a good while) on trunk because of IFC (IFC progression). This test also checks the container height but that assumes the "Ahem" font being installed on the system (30px vs. 33px). -Chrome fails too when "Ahem" is deactivated.
Let's close it.