Bug 249140
| Summary: | Fix reset to baseVal after animation end for SVGTransformList | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rbuis, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Nikolas Zimmermann
Partly revert the fix from webkit.org/b/198576 (REGRESSION (r243121): Load event
should not be fired while animating the 'externalResourcesRequired' attribute),
that landed in https://commits.webkit.org/212621@main.
First of all, externalResourcesRequired support is gone from WebKit, therefore
SMIL animations of that property are no longer possible: the workaround is obsolete.
More importantly, the applied workaround is harmful for SVGTransformList animations,
which go through the same SVGAnimatedPropertyAnimator code paths to apply changes,
when <animateTransform> animations are active.
@said: I hope the ChangeLog is sufficient :-)
[I wanted to mark this as depends-on 198576, but I have no rights to do so]
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Nikolas Zimmermann
Pull request: https://github.com/WebKit/WebKit/pull/7481
Nikolas Zimmermann
It's a draft PR, still need to update baseline / eventually add a new test (broke this out of a chain of commits, waiting for my builds to catch up... :-)
Radar WebKit Bug Importer
<rdar://problem/103512849>
EWS
Committed 268987@main (5a8f69dc67ce): <https://commits.webkit.org/268987@main>
Reviewed commits have been landed. Closing PR #7481 and removing active labels.