Bug 249104

Summary:	[css-grid] GridMasonryLayout::addItemsToFirstTrack remove unnecessary nullptr check
Product:	WebKit	Reporter:	Sammy Gill <sgill26>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Sammy Gill

Reported 2022-12-11 11:53:42 PST

GridMasonryLayout::addItemsToFirstTrack iterators over a HashMap that uses raw pointers as keys. The HashMap implementation would not allow this to happen so we can probably remove the check

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-12-11 11:54:01 PST

<rdar://problem/103230303>

Sammy Gill

Comment 2 2022-12-11 12:03:45 PST

Pull request: https://github.com/WebKit/WebKit/pull/7455

EWS

Comment 3 2022-12-11 21:11:31 PST

Committed 257714@main (3f50a04024eb): <https://commits.webkit.org/257714@main> Reviewed commits have been landed. Closing PR #7455 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.