Bug 249045

Summary:	[ews] Improve handling of non-existing status-bubbles
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Description Aakash Jain 2022-12-09 14:34:13 PST

[ews] Improve handling of non-existing status-bubbles on Github.

Comment 1 Radar WebKit Bug Importer 2022-12-09 14:34:50 PST

<rdar://problem/103194910>

Comment 2 Aakash Jain 2022-12-09 14:36:31 PST

Exception from logs:

  File "/var/ews/OpenSource/Tools/CISupport/ews-app/ews/common/github.py", line 230, in generate_comment_text_for_change
    comment_for_row += self.github_status_for_queue(change, queue)
  File "/var/ews/OpenSource/Tools/CISupport/ews-app/ews/common/github.py", line 272, in github_status_for_queue
    return u'| [{icon} {name} ]({url} "{hover_over_text}") '.format(icon=icon, name=name, url=url, hover_over_text=hover_over_text)
UnboundLocalError: local variable 'url' referenced before assignment

Comment 3 Aakash Jain 2022-12-09 14:37:06 PST

Pull request: https://github.com/WebKit/WebKit/pull/7410

Comment 4 EWS 2022-12-09 15:11:50 PST

Committed 257648@main (7d063a43b838): <https://commits.webkit.org/257648@main>

Reviewed commits have been landed. Closing PR #7410 and removing active labels.