Bug 249027

Summary: [@property] Add more syntax types
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189692    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Antti Koivisto
Reported 2022-12-09 10:06:55 PST
Add Percentage, Integer, Number and Angle types.
Attachments
Patch (60.66 KB, patch)
2022-12-09 10:09 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (61.03 KB, patch)
2022-12-09 10:10 PST, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (60.87 KB, patch)
2022-12-09 11:50 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-12-09 10:07:16 PST
<rdar://problem/103184764>
Antti Koivisto
Comment 2 2022-12-09 10:09:10 PST
Created attachment 463963 [details] Patch
Antti Koivisto
Comment 3 2022-12-09 10:10:55 PST
Created attachment 463964 [details] Patch
Antti Koivisto
Comment 4 2022-12-09 11:50:07 PST
Created attachment 463967 [details] Patch
Darin Adler
Comment 5 2022-12-09 12:06:34 PST
Comment on attachment 463967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463967&action=review > Source/WebCore/css/CSSCustomPropertyValue.h:46 > + struct NumericSyntaxValue { > + double value; > + CSSUnitType unitType; > + > + bool operator==(const NumericSyntaxValue&) const = default; > + }; > + using VariantValue = std::variant<std::monostate, Ref<CSSVariableReferenceValue>, CSSValueID, Ref<CSSVariableData>, Length, NumericSyntaxValue>; I want to use this kind of type for some other purposes too. Like when CSSProperties.json writes out "initial values", I want a constexpr value that can be a CSSValueID or numeric syntax.
EWS
Comment 6 2022-12-10 00:28:57 PST
Committed 257678@main (fba580ad5100): <https://commits.webkit.org/257678@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463967 [details].
Note You need to log in before you can comment on or make changes to this bug.