Bug 249024

Summary: [css-grid] Clean up management of masonry items
Product: WebKit Reporter: Sammy Gill <sgill26>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Sammy Gill 2022-12-09 09:05:59 PST
During the initial steps of masonry, we iterate over all the grid items and separate them into different structures to use in different parts of the algorithm. There are 2 main things that can be done to improve the quality of the code:

1.) Instead of storing the items using raw pointers, we should use WeakPtrs/CheckPtrs or std::reference_wrapper 
2.) At the end of the layout we should probably clear these collections so it is obvious we intend not to use them after layout
Comment 1 Radar WebKit Bug Importer 2022-12-09 09:06:16 PST
<rdar://problem/103182671>