Bug 249006

Created attachment 463952 [details]
Patch

Created attachment 463954 [details]
Patch

Comment on attachment 463954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463954&action=review

> Source/WebCore/rendering/RenderObject.cpp:874
> +    return ancestorRenderer.effectiveOverflowX() != Overflow::Visible && ancestorRenderer.effectiveOverflowY() != Overflow::Visible;

hasNonVisibleOverflow()?

> LayoutTests/fast/repaint/incorrect-repaint-when-child-layer-overflows.html:42
> +  document.body.offsetHeight;

The rendering update should do the layout.

> LayoutTests/fast/repaint/incorrect-repaint-when-child-layer-overflows.html:49
> +  wrapper.style.transform = "translateY(0)";
> +  contents.style.visibility = "visible";

My preferred way to do this is just `document.body.classList.add('changed')` and then just write style rules to match.

Comment on attachment 463954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463954&action=review

> LayoutTests/fast/repaint/incorrect-repaint-when-child-layer-overflows.html:27
> +  z-index: -10;

Is the negative z-index needed?

Created attachment 463960 [details]
[fast-cq]Patch

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 463954 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=463954&action=review
> 
> > Source/WebCore/rendering/RenderObject.cpp:874
> > +    return ancestorRenderer.effectiveOverflowX() != Overflow::Visible && ancestorRenderer.effectiveOverflowY() != Overflow::Visible;
> 
> hasNonVisibleOverflow()?
Oh, the cached bit on the renderer! Yeah, good point (though I find the function name a bit misleading. To me, hasNonVisibleOverflow() on a renderer means actual overflow in layout terms and not in style terms).

> 
> > LayoutTests/fast/repaint/incorrect-repaint-when-child-layer-overflows.html:42
> > +  document.body.offsetHeight;
> 
> The rendering update should do the layout.
cool, removed both calls.

> 
> > LayoutTests/fast/repaint/incorrect-repaint-when-child-layer-overflows.html:49
> > +  wrapper.style.transform = "translateY(0)";
> > +  contents.style.visibility = "visible";
> 
> My preferred way to do this is just `document.body.classList.add('changed')`
> and then just write style rules to match.
I like seeing the actual changes in the script, it's easier for me to tell what's going on. I'd prefer to keep it this way unless you feel strongly about it.

>> LayoutTests/fast/repaint/incorrect-repaint-when-child-layer-overflows.html:27
>> +  z-index: -10;
>Is the negative z-index needed?
Surely not, moved the .ref _before_ the test content.

Committed 257627@main (7ca99fc4ae5f): <https://commits.webkit.org/257627@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463960 [details].