Bug 248970

Summary: [ews] Increase pass percentage threshold for considering pre-existing failure using results database
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204368

Description Aakash Jain 2022-12-08 13:01:38 PST
We should increase pass percentage threshold for considering pre-existing failure using results database.

In https://ews-build.webkit.org/#/builders/73/builds/21647 and https://ews-build.webkit.org/#/builders/73/builds/21648

imported/w3c/web-platform-tests/fullscreen/api/document-exit-fullscreen-nested-shadow-dom.html was pre-existing failure, but ews didn't skip it based on results-database since results-database showed a pass rate of 63% for it for that configuration/revision. We should increase the threshold so that we actually consider such failures as pre-existing.

Results db url for that test: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Ffullscreen%2Fapi%2Fdocument-exit-fullscreen-nested-shadow-dom.html
Comment 1 Radar WebKit Bug Importer 2022-12-08 13:04:49 PST
<rdar://problem/103143262>
Comment 2 Aakash Jain 2022-12-08 13:06:18 PST
Pull request: https://github.com/WebKit/WebKit/pull/7341
Comment 3 EWS 2022-12-08 14:11:00 PST
Committed 257587@main (28e425e44102): <https://commits.webkit.org/257587@main>

Reviewed commits have been landed. Closing PR #7341 and removing active labels.