| Summary: | length values in gradients should take effective zoom into account | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||||
| Component: | CSS | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, sam, simon.fraser, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=18511 | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 463933 [details]
radial-gradient-and-zoom.html
Created attachment 463935 [details]
WIP patch
Created attachment 463948 [details]
Patch
Comment on attachment 463948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463948&action=review > Source/WebCore/rendering/style/StyleGradientImage.cpp:671 > +static float positionFromValue(const CSSPrimitiveValue& initialValue, const CSSToLengthConversionData& conversionData, const FloatSize& size, bool isHorizontal, const RenderStyle& style) Instead of passing the style in more places, should we put the effectiveZoom value into CSSToLengthConversionData? In fact, CSSToLengthConversionData seems to have the style already. Comment on attachment 463948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463948&action=review >> Source/WebCore/rendering/style/StyleGradientImage.cpp:671 >> +static float positionFromValue(const CSSPrimitiveValue& initialValue, const CSSToLengthConversionData& conversionData, const FloatSize& size, bool isHorizontal, const RenderStyle& style) > > Instead of passing the style in more places, should we put the effectiveZoom value into CSSToLengthConversionData? In fact, CSSToLengthConversionData seems to have the style already. Will fix. Thank you. Created attachment 463969 [details]
Patch
Comment on attachment 463969 [details]
Patch
So much cleaner!
Committed 257659@main (18a30951bbec): <https://commits.webkit.org/257659@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463969 [details]. *** Bug 248906 has been marked as a duplicate of this bug. *** |
Created attachment 463932 [details] linear-gradient-and-zoom.html absolute length values in gradients should take effective zoom into account