Bug 248901
| Summary: | Add SelectionMode enum for setRangeText() in HTMLInputElement and HTMLTextAreaElement | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | akeerthi, karlcow, rniwa, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://jsfiddle.net/fuj60bma/show | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another potential merge:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=199316
Just wanted to raise this bug so this can be tracked.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
I see the differences in the code and the tests
https://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/forms/resources/common-setrangetext.js?r1=199316&r2=199315&pathrev=199316
https://searchfox.org/wubkat/rev/e87eb5586000c2885aac4f138e394e8236aab3dd/LayoutTests/fast/forms/resources/common-setrangetext.js#86-89
but at the same time I see all tests passing on WPT.
https://wpt.fyi/results/html/semantics/forms/textfieldselection/textfieldselection-setRangeText.html?label=master&label=experimental&aligned&view=subtest&q=setrangetext
Wenson or Ryosuke might give a informed opinion about it.
Radar WebKit Bug Importer
<rdar://problem/103369726>
Ahmad Saleem
I took a test from our tree, which Blink modified via patch and changed in JSFiddle and we pass all tests (have old behavior) while Chrome Canary 118 and Firefox Nightly 118 both fail subset of tests on same error, so we have odd behavior compared to other browsers, so I think we should merge this and align our behavior with other browsers.
Adding 'BrowserCompat' tag as well.
Ahmad Saleem
After updating to latest `common-setrangetext.js` from Blink, we do fail tests:
> fast/forms/search/search-setrangetext.html
> fast/forms/setrangetext.html
> fast/forms/textarea/textarea-setrangetext.html