Bug 248792
| Summary: | [Wasm] Failures in ref_types.js test | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Asumu Takikawa <asumu> |
| Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Asumu Takikawa
There are currently some failing tests from the typed funcref tests (wasm.yaml/wasm/function-references/ref_types.js). It looks like a difference in type printing for `global.set` was introduced in 85f4c97a6e063901a359c620aa1007c7c3ebd7ea.
Either the test expectations should change or the type printing should change I think (https://bugs.webkit.org/show_bug.cgi?id=247452 made the type printing print the whole type instead of just the kind in other places, so it could make sense to be consistent with that).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Asumu Takikawa
This was fixed recently in https://github.com/WebKit/WebKit/commit/c3cabf531d738de5d543050e84fc0584b58fc449 and can be closed.