Bug 248700

Summary: Unexpected Contenteditable and FullScreen Behavior after first interaction
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: beidson, bfulgham, ntim, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Testcase none

Description Ahmad Saleem 2022-12-02 17:39:01 PST 
Hi Team,

While going through Blink's commit, I came across interesting case where Safari 16.1 behave strange compared to Chrome Canary 110.

Test Case - https://jsfiddle.net/esnjd59z/

Based of Blink's Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=179436

*** Safari 16.1 Behavior ***

1) Run JSFiddle
2) Click anywhere on the result, it will go to fullscreen
3) Close full screen
4) Now click again to do full screen

>>> EXPECTED RESULT:

Go full screen again

>>> ACTUAL RESULT:

It do splash and go fullscreen and come back again. (Also first time, it would be white full screen but later it would be dark full screen - seems odd).

________

Chrome Canary 110 behave correctly and full screen and then you have to dismiss it.

I think it is more of graceful handling of how to do it rather than splash causing seizure like experience for some users.

Just wanted to raise it so this can be considered in future.

Thanks!
Comment 1 Radar WebKit Bug Importer 2022-12-09 17:39:18 PST 
<rdar://problem/103201104>
Comment 2 Tim Nguyen (:ntim) 2023-01-09 02:07:05 PST 
Created attachment 464417 [details]
Testcase
Comment 3 Tim Nguyen (:ntim) 2023-01-09 02:13:40 PST 
> (Also first time, it would be white full screen but later it would be dark full screen - seems odd).

That part has been fixed with my changes.

Other that that, I'm not sure I'm understanding the bug that you see, the animation is different between Safari & Chrome, but nothing looks broken to me.

It's worth testing again when STP 161 comes out with all of my changes.
Comment 4 Ahmad Saleem 2023-01-09 02:15:25 PST 
(In reply to Tim Nguyen (:ntim) from comment #3)
> > (Also first time, it would be white full screen but later it would be dark full screen - seems odd).
> 
> That part has been fixed with my changes.
> 
> Other that that, I'm not sure I'm understanding the bug that you see, the
> animation is different between Safari & Chrome, but nothing looks broken to
> me.
> 
> It's worth testing again when STP 161 comes out with all of my changes.

Will do and usually I also go through all my old bugs and some with fixes to see if any other related bugs are also fixed or not. Thanks for your input!
Comment 5 Ahmad Saleem 2023-01-12 15:49:26 PST 
(In reply to Tim Nguyen (:ntim) from comment #3)
> > (Also first time, it would be white full screen but later it would be dark full screen - seems odd).
> 
> That part has been fixed with my changes.
> 
> Other that that, I'm not sure I'm understanding the bug that you see, the
> animation is different between Safari & Chrome, but nothing looks broken to
> me.
> 
> It's worth testing again when STP 161 comes out with all of my changes.

Checking with STP161, the behavior is more refined and better than Safari 16.2 and similar to Chrome Canary 111.

I am closing this as "RESOLVED CONFIGURATION CHANGED".