Bug 248682
| Summary: | Clean up some options initialization workflow. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
We always call correctOptions() before recomputeDependentOptions(), and often call dumpOptionsIfNeeded() and ensureOptionsAreCoherent() after.
This patch makes things more consistent by:
1. Rename recomputeDependentOptions() to notifyOptionsChanged().
2. Rename ensureOptionsAreCoherent() to assertOptionsAreCoherent(), because "ensure" implies that the function will make them coherent. Instead, the function asserts that they are coherent.
3. Move the body of correctOptions() (which is a tiny function) into the top of notifyOptionsChanged().
4. Call dumpOptionsIfNeeded() and assertOptionsAreCoherent() at the end of notifyOptionsChanged() instead of from clients.
5. Make sure clients call notifyOptionsChanged() after changing options.
Additionally:
6. Rename ExecutableAllocator:: setJITEnabled() to ExecutableAllocator::disableJIT(). Disabling JIT in this function was always a one way street, and there's no going back. This rename makes it clear and explicit.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/102916238>
Mark Lam
<rdar://problem/102916238>
Mark Lam
<rdar://problem/102844335>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/7095
EWS
Committed 257311@main (6d72ef261e4a): <https://commits.webkit.org/257311@main>
Reviewed commits have been landed. Closing PR #7095 and removing active labels.