Bug 248628
| Summary: | Remove ApplePasteAsQuotation class handling | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | rniwa, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another about removing old code:
Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/5c10c52ba10b124c002ab47a7165d983d9869e51
Webkit GitHub Source (Example) - https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/Editor.cpp#L1592 & https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L1077 & https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L513
Just wanted to raise bug to remove it after input from others that it is not used internally and we can remove it safely.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
PR - https://github.com/WebKit/WebKit/pull/7320
Radar WebKit Bug Importer
<rdar://problem/103143565>
Ahmad Saleem
Ryosuke mentioned on PR that we cannot remove this code right now but if you want to see the patch and code, which I am removing and do it in future. You can do follow my PR link.
I will close my PR now. Thanks!
@rniwa - thanks for your support. Just ping me, in future, if you want me to remove this. :-)